Sample FruitsMerge #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DzmitryKharko
requested review from
AlexMerzlikin,
eldarmguseynov and
perepechenko
| { | ||
| await UniTask.Yield(); | ||
| if (cancellationToken.IsCancellationRequested) | ||
| { |
There was a problem hiding this comment.
Consider throwing an operation cancelled exception simply passing CT into yield
| /// RootLifetimeScope sets up the DI container for the game application, configuring essential components such as | ||
| /// the entry point (Bootstrap), controllers, and services. This setup ensures efficient dependency management and lifecycle handling during gameplay. | ||
| /// </summary> | ||
| public class RootLifetimeScope : LifetimeScope |
There was a problem hiding this comment.
Consider not to use LifetimeScope cause it's tied to unity engine lifecycle. Try to keep control code centric.
| protected override async UniTask OnFlowAsync(CancellationToken cancellationToken) | ||
| { | ||
| _view = await _factory.CreateAsync(_data.ResourceId, cancellationToken); | ||
| cancellationToken.ThrowIfCancellationRequested(); |
There was a problem hiding this comment.
you can safely remove all cancellationToken.ThrowIfCancellationRequested(), cause asynchronous operations you're using will throw an exception anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT Create sample for ControllersTree package