-
Notifications
You must be signed in to change notification settings - Fork 140
Remove things that need to be removed #1902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
codemob-dev
wants to merge
13
commits into
PixelGuys:master
Choose a base branch
from
codemob-dev:remove-things
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+0
−1,035
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e90a863
Remove json
codemob-dev 4a32fed
Remove more stuff
codemob-dev 965e957
Remove the old server asset deletion code
codemob-dev 67f6fe8
Remove more things
codemob-dev 8f0eec2
Fix formatting
codemob-dev 529515a
Remove things that should have been removed by codemob
IntegratedQuantum 3b9d621
Start the 0.1.0 doelvlopment cycle
IntegratedQuantum edaf9e7
Fancy fern model (#1899)
careeoki c163a4a
Add a link to the releases in the run section in the README.
IntegratedQuantum 663c52a
Use "xdg-open" instead of "open" (#1925)
Damglador b513a6f
Make amber spawn on beaches (#1905)
careeoki 7c15aaf
Rename .zig-version to .zigversion (#1935)
ruckustboom 16b3683
Merge branch 'master' into remove-things
codemob-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this can be removed just like that?
If understand this correctly this would break loading the initial player inventory from the server.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the inventory still sent as zon from the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played as much as I could and it is saving the inventory correctly, even in multiplayer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, where is the inventory then loaded from network on the client side? Can we maybe even remove the parent function as well?