Skip to content

Conversation

jingkaimori
Copy link
Contributor

this pr may close 1574
rendered input box

@ikabod-kee
Copy link
Collaborator

Oh that's cute

@Argmaster
Copy link
Collaborator

This may help but it's not enough, cursor is simply to thin on 4k displays, regardless of color.

@ikabod-kee
Copy link
Collaborator

It'd also be fixed with pixel consistency via #1004

@jingkaimori
Copy link
Contributor Author

jingkaimori commented Jun 18, 2025

cursor is simply to thin on 4k displays

All input box (including those provided by well-developed website such as github) on my browser has a cursor of such width.

@jingkaimori
Copy link
Contributor Author

a wider version:
rendered input box

@Argmaster
Copy link
Collaborator

Wider version has much better visibility. I am primarily concerned with visibility in chat.

@IntegratedQuantum
Copy link
Member

@careeoki @ikabod-kee I would like to hear your opinion on this and if this fits into your UI design.

@ikabod-kee
Copy link
Collaborator

It'll probably be changed with the UI revamp anyways, so it's fine.

@IntegratedQuantum
Copy link
Member

It'll probably be changed with the UI revamp anyways, so it's fine.

I don't know what your expectation is, but there will not be a full from scratch rewrite of the GUI system.
Also I'd argue this is a small part of the UI revamp. That's why I am asking for your opinion here.

@ikabod-kee
Copy link
Collaborator

I think it should be grey, not wood-colored.

@jingkaimori
Copy link
Contributor Author

jingkaimori commented Jun 30, 2025

input box with grey cursor and text save3
grey cursor, seems not distinguishable enough.

@ikabod-kee where is UI rewrite branch? should this pr targets to that branch?

@Argmaster
Copy link
Collaborator

Argmaster commented Jun 30, 2025

There is no UI rewrite branch and there will be no rewrite branch, we just have a bunch of redesigns of UIs planned, none of that started quite yet.

@jingkaimori jingkaimori force-pushed the cursor-color-adjustment branch from b68c806 to c517871 Compare June 30, 2025 14:42
@ikabod-kee
Copy link
Collaborator

Try a lighter grey! :)

@jingkaimori
Copy link
Contributor Author

图片
a ligher grey, though IMO grey does not fits here

@ikabod-kee
Copy link
Collaborator

It honestly looks fine

Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how the wide cursor now cuts of some of the letters.
Screenshot at 2025-07-13 12-07-49
Maybe instead of making it wider the solution would be to just make it white for maximum contrast with the background and have it blink, as is the case in many normal text editors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants