Change fallen log and simple trees to use new logs #1575
Conversation
| .id = "cubyz:simple_tree", | ||
| .leaves = "cubyz:air", | ||
| .log = "cubyz:cactus", | ||
| .top = "cubyz:cactus_flower", |
There was a problem hiding this comment.
This breaks the behavior. Now cacti will no longer spawn with a flower on top.
Also should use log/cactus.
There was a problem hiding this comment.
I think you should make a new structure for this, or add an optional argument to simple structure, abusing the tree was kind of hacky to begin with.
There was a problem hiding this comment.
I didn't see a fix for this.
| return self; | ||
| } | ||
|
|
||
| fn getWoodBlock(self: *SimpleTreeModel, data: u16) main.blocks.Block { |
There was a problem hiding this comment.
Shouldn't pass the branch data, instead it should just pass the Neighbor and calculate the data in here.
This would make the callsite cleaner and could allow expanding this with other rotation modes (e.g. if we ever need to support the old rotation again)
There was a problem hiding this comment.
I can't because there are cases where multiple sides need to be connected at once
There was a problem hiding this comment.
Then pass multiple sides
There was a problem hiding this comment.
That is what data is doing. Data right now is just the bitmask of which sides are enabled or not
There was a problem hiding this comment.
Then name it accordingly, and not just data. Also should be at least a u6 if not a packed struct.
|
please address the remaining change requests |
No description provided.