-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/pie 10.1.0 #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from some comments here, overall I'd like to look at this more closely and make some changes before merging.
@@ -1,96 +1,36 @@ | |||
# File Uploader | |||
# Image Upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about file uploads? Like a video file or audio file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have it implemented right now, can we add it once it's implemented? maybe put in a coming soon? It'll be pretty similar to image upload.
``` | ||
|
||
|
||
#### name (required) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why removing these sections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt that it was just repeating what npm documents already, so not needed?
No description provided.