-
Notifications
You must be signed in to change notification settings - Fork 0
Merge master main #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Fix unit test CMake bug and small typos * Fix bug when building with ros when testing is off * Revert commit and eliminate BUILD_TESTING check
* extend JSOn convertion to include vectors * fixing comments
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Just to clarify, is BehaviorTree.CPP's master or Picknik's fork master. |
PickNik's fork master that is synced with BTCPP master |
I think we should do some more testing to make sure this is going to be ok, there are a lot of changes and I see Davide made some changes to the JSON serialization stuff too which could mess with the work we did to pass things through to the blackboard viewer 0b06807 |
I created a PR that rebases our main branch on the upstream master branch and reverts Davide's upstream json changes that clash with ours and it builds and passes the local tests so that will probably be a better point to work from #15. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see last comment
No description provided.