Skip to content

New EVA voice after deploying a building #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

FS-21
Copy link
Contributor

@FS-21 FS-21 commented May 27, 2025

  • You can now replace the current EVA voice when a specific building is placed/deployed.
  • If any buiding is undeployed/sold/destroyed EVA voice will be evaluated again looking all the NewEVAVoice.Index.
  • NewEVAVoice.Index is the index of the new EVA voice. Ares is hightly recomended because these indexes are reading the new section [EVATypes] at evamd.ini introduced by Ares. Look at Ares documentation regarding new EVA voices for more information.
  • In case of multiple buildings with different NewEVAVoice.Index EVA voices then NewEVAVoice.Priority establish a priority queue, being the highest value the selected one.
  • NewEVAVoice.RecheckOnDeath re-checks a new EVA voice after the destruction/undeployment of of of these buildings.
  • NewEVAVoice.InitialMessage plays an EVA message to the player when a different EVA has been selected.

In rulesmd.ini:

[SOMEBUILDING]                    ; BuildingType
NewEVAVoice.Index=                ; integer
NewEVAVoice.Priority=1            ; integer
NewEVAVoice.RecheckOnDeath=false  ; boolean
NewEVAVoice.InitialMessage=       ; EVA entry

@FS-21 FS-21 marked this pull request as draft May 27, 2025 11:15
FS-21 added 2 commits May 28, 2025 08:40
- The player will hear only his own EVA voices from the tag NewEVAVoice.InitialMessage.
- The readed data of the [EVATypes] was deleted before it was used by the new code.
- Small fixes & tweaks.
@FS-21 FS-21 marked this pull request as ready for review May 28, 2025 07:04
@FS-21
Copy link
Contributor Author

FS-21 commented May 28, 2025

2025-05-28.09-02-10.mp4

Copy link

github-actions bot commented May 28, 2025

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Copy link
Contributor

@Starkku Starkku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EVA voice change logic should be generalized and put in a separate function from buildings, probably in SideExt or something. Firestorm has a map trigger for this purpose and I suppose someone might want to reimplement that here as well.

Some smaller things to take note of as well.

@Starkku Starkku force-pushed the develop branch 2 times, most recently from b429215 to 280b1c8 Compare June 29, 2025 19:13
@FS-21
Copy link
Contributor Author

FS-21 commented Jul 7, 2025

The EVA voice change logic should be generalized and put in a separate function from buildings, probably in SideExt or something. Firestorm has a map trigger for this purpose and I suppose someone might want to reimplement that here as well.

Some smaller things to take note of as well.

Since Ares already has Map trigger actions for changing these voices like in Firestorm I only focused in learning how to change it and apply this logic for buildings like in the video, not reimplementing again the EVA voices.

Let me see the SideExt you mentioned because I remember one of the first attempts was storing data in that place but things happened that made me move the code and I ended here.

FS-21 added 2 commits July 8, 2025 08:19
- Removed NewEvaVoice tag.
- NewEvaVoice.Index now is nullable int and the checks are against this value instead of the old NewEvaVoice.
@FS-21
Copy link
Contributor Author

FS-21 commented Jul 8, 2025

Applied feedback and updated documentation and initial message here.

The missing bit I have to do now is that suggestion of moving the code into a separated function from buildings to SideExt for future changes/additions, etc.

FS-21 added 2 commits July 8, 2025 08:38
Function UpdateMainEvaVoice(...) moved from Buildings to side class.
@FS-21
Copy link
Contributor Author

FS-21 commented Jul 8, 2025

Moved the UpdateMainEvaVoice(...) function to SideExt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants