Skip to content

Allow selecting by title. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victorwon wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow selecting by title. #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff49533
Allow selecting by title.
victorwon Aug 22, 2017
fa03d7c
Made the tappable area wider in case the initial title is too small.
victorwon Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions Source/BTNavigationDropdownMenu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ open class BTNavigationDropdownMenu: UIView {
}

// Get titleSize
let titleSize: CGSize
var titleSize = CGSize.zero
let titleToDisplay: String

switch title{
Expand All @@ -294,7 +294,9 @@ open class BTNavigationDropdownMenu: UIView {
titleToDisplay = title
}

titleSize = (titleToDisplay as NSString).size(attributes: [NSFontAttributeName:self.configuration.navigationBarTitleFont])
if let maxTitle = items.max(by: {$1.characters.count > $0.characters.count}) {
titleSize = (maxTitle as NSString).size(attributes: [NSFontAttributeName:self.configuration.navigationBarTitleFont])
}

// Set frame
let frame = CGRect(x: 0, y: 0, width: titleSize.width + (self.configuration.arrowPadding + self.configuration.arrowImage.size.width)*2, height: self.navigationController!.navigationBar.frame.height)
Expand All @@ -308,7 +310,7 @@ open class BTNavigationDropdownMenu: UIView {
self.menuButton = UIButton(frame: frame)
self.menuButton.addTarget(self, action: #selector(BTNavigationDropdownMenu.menuButtonTapped(_:)), for: UIControlEvents.touchUpInside)
self.addSubview(self.menuButton)

self.menuTitle = UILabel(frame: frame)
self.menuTitle.text = titleToDisplay
self.menuTitle.textColor = self.menuTitleColor
Expand Down Expand Up @@ -413,14 +415,23 @@ open class BTNavigationDropdownMenu: UIView {
}
}

open func setSelected(index: Int) {
open func setSelected(index: Int?) {
self.tableView.selectedIndexPath = index
self.tableView.reloadData()

guard let index = index else {
self.setMenuTitle("")
return
}

if self.shouldChangeTitleText! {
self.setMenuTitle("\(self.tableView.items[index])")
}
}

open func setSelectedByTitle(title: String) {
self.setSelected(index: self.items.index(of: title))
}

func setupDefaultConfiguration() {
self.menuTitleColor = self.navigationController?.navigationBar.titleTextAttributes?[NSForegroundColorAttributeName] as? UIColor
Expand Down