handle querydevice error #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged and a release pushed? @tom-thorne @dominicrathbone |
dominicrathbone
approved these changes
Jul 14, 2021
dominicrathbone
requested changes
Jul 14, 2021
|
Honestly, looking at this again it is more descriptive but not helpful to an engineer to throw this error because there is no code or anything to guard it/check it. |
My intent was to point out an unhandled error and provide an example of a method of detecting it and handling it. You're welcome to address it however you like. I'm content using my own fork until a satisfactory solution is introduced upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles edge case in error handling, bug on Apple's end