Disable fill-shots on default.qubit for one-shot and tree-traversal #8411
+163
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.43.0-rc0 #8411 +/- ##
==============================================
Coverage ? 99.42%
==============================================
Files ? 584
Lines ? 61242
Branches ? 0
==============================================
Hits ? 60890
Misses ? 352
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
albi3ro
approved these changes
Oct 7, 2025
mudit2812
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When using
mcm_method="one-shot"or"tree-traversal", combined withpostselect_mode="fill-shots", the postselection breaks the correlation between correlated measurements completely, producing incorrect results. The only way to fix that is by continuously running the simulation until we have enough valid shots, which fundamentally goes against the philosophy of treating shots as a budget constraint. Therefore, we have opted to disallow"fill-shots"for anything but"deferred"indefault.qubit.Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-100562]
[sc-99992]
Fixes #8366
#8332