Skip to content

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 6, 2025

Context:

A performance regression was found to have occured when we added dynamic wire allocation to the device preprocessing.

Description of the Change:

Improves the performance of resolve_dynamic_wires.

Benefits:

Screenshot 2025-10-07 at 8 51 16 AM

Possible Drawbacks:

Related GitHub Issues:

[sc-100956]

@albi3ro albi3ro changed the base branch from master to v0.43.0-rc0 October 6, 2025 15:15
@andrijapau andrijapau added this to the v0.43 milestone Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v0.43.0-rc0@d8382e4). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v0.43.0-rc0    #8406   +/-   ##
==============================================
  Coverage               ?   99.42%           
==============================================
  Files                  ?      584           
  Lines                  ?    61241           
  Branches               ?        0           
==============================================
  Hits                   ?    60890           
  Misses                 ?      351           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albi3ro albi3ro requested a review from jzaia18 October 7, 2025 12:46
Copy link
Contributor

@jzaia18 jzaia18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, performance in the benchmark suite seems to be improved!

@albi3ro albi3ro enabled auto-merge (squash) October 7, 2025 15:48
@albi3ro albi3ro merged commit a5b00f1 into v0.43.0-rc0 Oct 7, 2025
49 checks passed
@albi3ro albi3ro deleted the fix-qscript-copy branch October 7, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants