-
Notifications
You must be signed in to change notification settings - Fork 705
Lazily dispatch grad and jacobian #8382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8382 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 584 584
Lines 61323 61338 +15
==========================================
+ Hits 60972 60986 +14
- Misses 351 352 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some tiny nitpick about the error message for non-qjit, and a question about performance in case of repeated execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me 🎉
Context:
When updating catalyst, I was getting extremely irritated by the fact that
qml.qjit(qml.grad(f))(*args)
does not work.Description of the Change:
Lazily dispatch grad and jacobian so we can do
qml.qjit(qml.grad(f))
andqml.qjit(qml.jacobian(f))
.Benefits:
Less rage. More intuitive experience.
Possible Drawbacks:
Related GitHub Issues:
[sc-100724]