Fix errorneous call to GetUserPath and update pop-up message #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Oct 30, 2025
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Oct 30, 2025
…age (#9082) * Apply changes from PathOfBuildingCommunity/PathOfBuilding-PoE2#1433 * Fix conflicts Refactor path retrieval to use fallback options. * Fix merge conflict Updated user settings path error message to provide clearer instructions. --------- Co-authored-by: Wires77 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This depends on PathOfBuildingCommunity/PathOfBuilding-SimpleGraphic#76 and attempts to mitigate the situation described in
02cf10a(#372)Most installations should be fine using the relative paths, but some exotic installs would not have these files in the correct relative location.
To test:
Have a legacy PoB setup, where the runtime files are stored separately from the script files. Change these directories to be Unicode so the bare-bones Lua runtime can't parse the path and will use the fallback path.