Exclude every assembly references not present in ours, but present in… #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the default ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the default ones
The problem I had was if I installed the bepinex package, it contains both OHarmony.dll and OHarmony20.dll. I think the latter is for older code, but the point is, they contain very similar types.
If I have an asmdef with the former, but not the latter, this should be valid because there's no ambiguity. However, unity actually references EVERYTHING by default including both dll. So while the code says to only put the assemblies we want in additionalRefferences, it doesn't exclude the ones unity wants, but we never said to want.
In debugging, I found the assemblies that end up getting excluded by this code aren't used at all and it even implies the previously built assembly as well which is what allows me to remove that where call.