feat: Add additional tests for DispatchAsync #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarchant
commented
Jul 9, 2025
| } | ||
| } | ||
|
|
||
| func wait() async { |
There was a problem hiding this comment.
Make sure to hide whitespace changes before reviewing this. It will be a lot easier.
scottmarchant
requested review from
NeedleInAJayStack,
Austinpayne and
CrownedPhoenix
33 tasks
scottmarchant
commented
Aug 8, 2025
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| // TODO: SM: Rename this file to AsyncSemaphoreTests (coming in next PR that adds tests) |
There was a problem hiding this comment.
Note, this file was renamed to AsyncSemaphoreTests
JaapWijnen
approved these changes
Aug 11, 2025
scottmarchant
force-pushed
the
feat/addAdditionalTests
branch
from
ae42424 to
a872ad4
Compare
clackary
approved these changes
Sep 23, 2025
|
|
||
| @testable import DispatchAsync | ||
|
|
||
| nonisolated(unsafe) private var sharedPoolCompletionCount = 0 |
There was a problem hiding this comment.
Is this nonisolated(unsafe) bit actually required here? I thought that was only necessary when opting out of actor-isolation. I don't quite know how to reason about it when it's on a file level variable.
|
|
||
| nonisolated(unsafe) private var sharedPoolCompletionCount = 0 | ||
|
|
||
| @Suite("DispatchGroup Tests") |
There was a problem hiding this comment.
Suggested change
| @Suite("DispatchGroup Tests") | |
| @Suite("AsyncSemaphore Tests") |
|
|
||
| private typealias DispatchQueue = DispatchAsync.DispatchQueue | ||
|
|
||
| /// Ping-Pong queue test is adapted from the test |
There was a problem hiding this comment.
nit: fix extra space
Suggested change
| /// Ping-Pong queue test is adapted from the test | |
| /// Ping-Pong queue test is adapted from the test |
CrownedPhoenix
approved these changes
Sep 24, 2025
[Human-Directed AI Assistance]
…/tests/dispatch_pingpong.c. [Human-Directed AI Assistance]
# Conflicts: # Tests/DispatchAsyncTests/DispatchGroupTests.swift # Conflicts: # Tests/DispatchAsyncTests/DispatchGroupTests.swift
…And other minor improvements to tests.
scottmarchant
force-pushed
the
feat/addAdditionalTests
branch
from
a872ad4 to
ee96d84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick summary
This PR adds a focused round of new and ported tests to harden the experimental
DispatchAsyncpackage:AsyncSemaphoreandDispatchTimeIntervalcover edge-cases that weren’t exercised before.dispatch_pingponganddispatch_group) rewritten in Swift to stress-test queue/group behaviour under concurrency.DispatchGroup.waitpublicly visible so the new tests compile.PR Dependencies
This branch is stacked on PR #1 – “Initial implementation of many GCD API’s using Swift Concurrency.”
PR #1 will need merged before this PR.