Persistence seam adoption #1822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
commented
Oct 17, 2025
| { | ||
| Defaults(s => | ||
| { | ||
| var defaultsAppliedSettingsKey = "NServiceBus.Persistence.Sql.DefaultsApplied"; |
There was a problem hiding this comment.
See 256ea09
Pretty sure this was needed because when you specified UsePersistence multiple times, there were multiple instances of the class we applied the defaults for, which would have led to a duplicate key exception due to the diagnostic section key already being used.
The new persistence seam will create the SqlPersistence only once
// cc @andreasohlund
danielmarbach
force-pushed
the
persistence-seam
branch
from
41533b1 to
8f4ea33
Compare
danielmarbach
force-pushed
the
persistence-seam
branch
from
8f4ea33 to
86b1105
Compare
1 task
DavidBoike
reviewed
Oct 20, 2025
DavidBoike
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages Particular/NServiceBus#7436