Skip to content

Persistence seam adoption #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

Persistence seam adoption #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbb949
Alpha.7
danielmarbach Oct 20, 2025
93af141
Adjust to persistence seam
danielmarbach Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ence.NonDurable.AcceptanceTests/NServiceBus.Persistence.NonDurable.AcceptanceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.0.0-alpha.6" GeneratePathProperty="true" />
<PackageReference Include="NServiceBus.AcceptanceTests.Sources" Version="10.0.0-alpha.7" GeneratePathProperty="true" />
</ItemGroup>

<ItemGroup Condition="'$(PkgNServiceBus_AcceptanceTests_Sources)' != ''">
Expand Down
2 changes: 1 addition & 1 deletion ...ce.NonDurable.PersistenceTests/NServiceBus.Persistence.NonDurable.PersistenceTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="NServiceBus.PersistenceTests.Sources" Version="10.0.0-alpha.6" />
<PackageReference Include="NServiceBus.PersistenceTests.Sources" Version="10.0.0-alpha.7" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/NServiceBus.Persistence.NonDurable.Tests/APIApprovals.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public void ApproveNonDurablePersistence()
{
var publicApi = typeof(NonDurablePersistence).Assembly.GeneratePublicApi(new ApiGeneratorOptions
{
ExcludeAttributes = new[] { "System.Runtime.Versioning.TargetFrameworkAttribute", "System.Reflection.AssemblyMetadataAttribute" }
ExcludeAttributes = ["System.Runtime.Versioning.TargetFrameworkAttribute", "System.Reflection.AssemblyMetadataAttribute"]
});
Approver.Verify(publicApi);
}
Expand Down
2 changes: 1 addition & 1 deletion ...nce.NonDurable.Tests/ApprovalFiles/APIApprovals.ApproveNonDurablePersistence.approved.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
[assembly: System.Runtime.CompilerServices.InternalsVisibleTo(@"NServiceBus.Persistence.NonDurable.Tests, PublicKey=00240000048000009400000006020000002400005253413100040000010001007f16e21368ff041183fab592d9e8ed37e7be355e93323147a1d29983d6e591b04282e4da0c9e18bd901e112c0033925eb7d7872c2f1706655891c5c9d57297994f707d16ee9a8f40d978f064ee1ffc73c0db3f4712691b23bf596f75130f4ec978cf78757ec034625a5f27e6bb50c618931ea49f6f628fd74271c32959efb1c5")]
namespace NServiceBus
{
public class NonDurablePersistence : NServiceBus.Persistence.PersistenceDefinition { }
public class NonDurablePersistence : NServiceBus.Persistence.PersistenceDefinition, NServiceBus.Persistence.IPersistenceDefinitionFactory<NServiceBus.NonDurablePersistence> { }
}
namespace NServiceBus.Persistence.NonDurable
{
Expand Down
2 changes: 1 addition & 1 deletion src/NServiceBus.Persistence.NonDurable/NServiceBus.Persistence.NonDurable.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</PropertyGroup>

<ItemGroup Label="Public dependencies">
<PackageReference Include="NServiceBus" Version="10.0.0-alpha.6" />
<PackageReference Include="NServiceBus" Version="10.0.0-alpha.7" />
</ItemGroup>

<ItemGroup Label="Private dependencies">
Expand Down
12 changes: 7 additions & 5 deletions src/NServiceBus.Persistence.NonDurable/NonDurablePersistence.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@
/// <summary>
/// Used to enable NonDurable persistence.
/// </summary>
public class NonDurablePersistence : PersistenceDefinition
public class NonDurablePersistence : PersistenceDefinition, IPersistenceDefinitionFactory<NonDurablePersistence>
{
internal NonDurablePersistence()
NonDurablePersistence()
{
Supports<StorageType.Sagas>(s => s.EnableFeatureByDefault<NonDurableSagaPersistence>());
Supports<StorageType.Subscriptions>(s => s.EnableFeatureByDefault<NonDurableSubscriptionPersistence>());
Supports<StorageType.Outbox>(s => s.EnableFeatureByDefault<NonDurableOutboxPersistence>());
Supports<StorageType.Sagas, NonDurableSagaPersistence>();
Supports<StorageType.Subscriptions, NonDurableSubscriptionPersistence>();
Supports<StorageType.Outbox, NonDurableOutboxPersistence>();
}

static NonDurablePersistence IPersistenceDefinitionFactory<NonDurablePersistence>.Create() => new();
}
}