Reduced compiler warnings

Makefile.am

@@ -57,7 +57,7 @@ par2_SOURCES = src/par2cmdline.cpp \
 par2_LDADD = libpar2.a
 
 LDADD = -lstdc++
-AM_CXXFLAGS = -Wall -std=c++11 $(OPENMP_CXXFLAGS)
+AM_CXXFLAGS = -Wall -Wextra -O3 -std=c++11 $(OPENMP_CXXFLAGS)
 
 EXTRA_DIST = PORTING ROADMAP \
 			 man/par2.1 \

config.h.in

@@ -31,9 +31,6 @@
 /* Define to 1 if you have the `memcpy' function. */
 #undef HAVE_MEMCPY
 
-/* Define to 1 if you have the <memory.h> header file. */
-#undef HAVE_MEMORY_H
-
 /* Define to 1 if you have the <ndir.h> header file, and it defines `DIR'. */
 #undef HAVE_NDIR_H
 
@@ -105,7 +102,9 @@
 /* Define to the version of this package. */
 #undef PACKAGE_VERSION
 
-/* Define to 1 if you have the ANSI C header files. */
+/* Define to 1 if all of the C90 standard headers exist (not just the ones
+   required in a freestanding environment). This macro is provided for
+   backward compatibility; new code need not use it. */
 #undef STDC_HEADERS
 
 /* Version number of package */
@@ -123,11 +122,6 @@
 # endif
 #endif
 
-/* Enable large inode numbers on Mac OS X 10.5.  */
-#ifndef _DARWIN_USE_64_BIT_INODE
-# define _DARWIN_USE_64_BIT_INODE 1
-#endif
-
 /* Number of bits in a file offset, on hosts where this is settable. */
 #undef _FILE_OFFSET_BITS
 

src/commandline.cpp

@@ -459,8 +459,10 @@ bool CommandLine::ReadArgs(int argc, const char * const *argv)
               {
                 case 'g':
                   redundancysize = redundancysize * 1024;
+                  break;
                 case 'm':
                   redundancysize = redundancysize * 1024;
+                  break;
                 case 'k':
                   redundancysize = redundancysize * 1024;
                   break;

src/descriptionpacket.cpp

@@ -149,6 +149,7 @@ string DescriptionPacket::UrlEncodeChar(char c)
 // system, we don't want to change the filenames.
 string DescriptionPacket::TranslateFilenameFromLocalToPar2(std::ostream &sout, std::ostream &serr, const NoiseLevel noiselevel, string local_filename)
 {
+  (void)sout;
   string par2_encoded_filename;
 
   string::iterator p = local_filename.begin();
@@ -260,6 +261,7 @@ string DescriptionPacket::TranslateFilenameFromLocalToPar2(std::ostream &sout, s
 // sure that anything can be done here for that.
 string DescriptionPacket::TranslateFilenameFromPar2ToLocal(std::ostream &sout, std::ostream &serr, const NoiseLevel noiselevel, string par2_encoded_filename)
 {
+  (void)sout;
   string local_filename;
 
   string::iterator p = par2_encoded_filename.begin();

src/galois.h

@@ -60,7 +60,7 @@ class Galois
   typedef valuetype ValueType;
 
   // Basic constructors
-  Galois(void) {};
+  Galois(void) : value(0) {};
   Galois(ValueType v);
 
   // Copy and assignment

src/galois_test.cpp

@@ -297,7 +297,7 @@ int test4() {
 // and 2^pow != 0 for any pow
 
 template<typename gtype, typename utype>
-int test_powers(const gtype two, const gtype zero, int max_value) {
+int test_powers(const gtype two, int max_value) {
   gtype g = two;
 
   int used[256*256];
@@ -331,11 +331,11 @@ int test_powers(const gtype two, const gtype zero, int max_value) {
 
 
 int test5() {
-  return test_powers<Galois8, u8>(Galois8(2), Galois8(0), 256);
+  return test_powers<Galois8, u8>(Galois8(2), 256);
 }
 
 int test6() {
-  return test_powers<Galois16, u16>(Galois16(2), Galois16(0), 256*256);
+  return test_powers<Galois16, u16>(Galois16(2), 256*256);
 }
 
 

src/libpar2.cpp

@@ -132,6 +132,7 @@ bool ComputeRecoveryFileCount(std::ostream &sout,
 			      u64 largestfilesize,
 			      u64 blocksize)
 {
+  (void)sout;
   // Are we computing any recovery blocks
   if (recoveryblockcount == 0)
   {

src/par2repairer.cpp

@@ -1120,7 +1120,7 @@ bool Par2Repairer::PrepareVerificationHashTable(void)
       if (0 != sourcefile->GetVerificationPacket())
       {
         // Yes. Load the verification entries into the hash table
-        verificationhashtable.Load(sourcefile, blocksize);
+        verificationhashtable.Load(sourcefile);
 
         blockverifiable = true;
       }

src/reedsolomon.cpp

@@ -54,6 +54,8 @@ u32 gcd(u32 a, u32 b)
 
 template <> bool ReedSolomon<Galois8>::SetInput(const vector<bool> &present, std::ostream &sout, std::ostream &serr)
 {
+  (void) sout;
+  (void) serr;
   inputcount = (u32)present.size();
 
   datapresentindex = new u32[inputcount];
@@ -83,6 +85,8 @@ template <> bool ReedSolomon<Galois8>::SetInput(const vector<bool> &present, std
 
 template <> bool ReedSolomon<Galois8>::SetInput(u32 count, std::ostream &sout, std::ostream &serr)
 {
+  (void) sout;
+  (void) serr;
   inputcount = count;
 
   datapresentindex = new u32[inputcount];
@@ -185,6 +189,8 @@ template <> bool ReedSolomon<Galois8>::InternalProcess(const Galois8 &factor, si
 // and compute the base values to use for the vandermonde matrix.
 template <> bool ReedSolomon<Galois16>::SetInput(const vector<bool> &present, std::ostream &sout, std::ostream &serr)
 {
+  (void) sout;
+  (void) serr;
   inputcount = (u32)present.size();
 
   datapresentindex = new u32[inputcount];
@@ -229,6 +235,8 @@ template <> bool ReedSolomon<Galois16>::SetInput(const vector<bool> &present, st
 // and compute the base values to use for the vandermonde matrix.
 template <> bool ReedSolomon<Galois16>::SetInput(u32 count, std::ostream &sout, std::ostream &serr)
 {
+  (void) sout;
+  (void) serr;
   inputcount = count;
 
   datapresentindex = new u32[inputcount];

src/reedsolomon.h

@@ -247,21 +247,25 @@ inline bool ReedSolomon<g>::Compute(NoiseLevel noiselevel, std::ostream &sout, s
                |(dpi[col])           |             | |(dmi[col])           |           |
                \                     |             / \                     |           /
   */
-
   // Allocate the left hand matrix
-
   leftmatrix = new G[outcount * incount];
-  memset(leftmatrix, 0, outcount * incount * sizeof(G));
 
-  // Allocate the right hand matrix only if we are recovering
+  // Use value initialization to initialize each element in the matrix to zero (or its default state)
+  for (size_t i = 0; i < outcount * incount; ++i) {
+      leftmatrix[i] = G();  // Default-construct each element (initialize to zero if G's constructor does that)
+  }
 
-  G *rightmatrix = 0;
+  // Allocate the right hand matrix only if we are recovering
+  G *rightmatrix = nullptr;
   if (datamissing > 0)
   {
-    rightmatrix = new G[outcount * outcount];
-    memset(rightmatrix, 0, outcount *outcount * sizeof(G));
+      rightmatrix = new G[outcount * outcount];
+
+      // Similarly, initialize the rightmatrix elements
+      for (size_t i = 0; i < outcount * outcount; ++i) {
+          rightmatrix[i] = G();  // Default-construct each element
+      }
   }
-
   // Fill in the two matrices:
 
   vector<RSOutputRow>::const_iterator outputrow = outputrows.begin();

src/reedsolomon_test.cpp

@@ -508,7 +508,7 @@ int test4(int NUM_IN, int *expected_bases) {
   for (int i = 0; i < NUM_IN; i++) {
     // read little-endian value
     utype v = 0;
-    for (int byte_index = 0; byte_index < sizeof(utype); byte_index++) {
+    for (long unsigned int byte_index = 0; byte_index < sizeof(utype); byte_index++) {
       u8 byte = data[NUM_IN+0][sizeof(utype)*i + byte_index];
       v |= (((utype)byte) << (byte_index*8));
     }

src/verificationhashtable.cpp

@@ -65,7 +65,7 @@ void VerificationHashTable::SetLimit(u32 limit)
 }
 
 // Load data from a verification packet
-void VerificationHashTable::Load(Par2RepairerSourceFile *sourcefile, u64 blocksize)
+void VerificationHashTable::Load(Par2RepairerSourceFile *sourcefile)
 {
   VerificationHashEntry *preventry = 0;
 

src/verificationhashtable.h

@@ -240,7 +240,7 @@ class VerificationHashTable
   void SetLimit(u32 limit);
 
   // Load the data from the verification packet
-  void Load(Par2RepairerSourceFile *sourcefile, u64 blocksize);
+  void Load(Par2RepairerSourceFile *sourcefile);
 
   // Try to find a match.
   //   nextentry   - The entry which we expect to find next. This is used