Give user option to exit post-install early in order to avoid issue with systemd on some container images. #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that have remnants of systemd, but no actual working systemd.
seabre
changed the title
seabre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script checks for the existence of
systemctlto determine of presence of systemd, which is fine. However, there are cases like with the Ubuntu 20.04 docker image where systemd is technically present, but won't work.This modification allows the user to set an environment variable
PDAGENT_SKIP_SERVICE_STARTin order to skip starting the service after the install. This is necessary, because if a start of pdagent's systemd service is attempted, then it will cause a failure. This is particularly annoying when building a Docker image. This change allows the user to avoid that problem.