Skip to content

Conversation

Jonathans575
Copy link
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 3.57143% with 54 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@d841351). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/tokenizer_utils.py 3.57% 27 Missing ⚠️
paddleformers/datasets/finetuning.py 3.70% 26 Missing ⚠️
paddleformers/trl/sftdata_config.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (3.57%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2676   +/-   ##
==========================================
  Coverage           ?   29.65%           
==========================================
  Files              ?      311           
  Lines              ?    54721           
  Branches           ?        0           
==========================================
  Hits               ?    16228           
  Misses             ?    38493           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lugimzzz lugimzzz merged commit 32e4a08 into PaddlePaddle:develop Sep 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants