Skip to content

Okonomiyaki3000: _log returns the class instance for method chaining #43 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2019
Merged

Okonomiyaki3000: _log returns the class instance for method chaining #43 #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe5b422
_log returns the class instance for method chaining
okonomiyaki3000 Apr 1, 2014
de8a354
Hmm. No reason to get the instance again when we already have it, eh?
okonomiyaki3000 Apr 1, 2014
8bc18b4
Update the docblock return value, always return , use empty instead o…
okonomiyaki3000 Apr 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions ChromePhp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,33 +244,31 @@ public static function table()
* internal logging call
*
* @param string $type
* @return void
* @return ChromePhp
*/
protected static function _log($type, array $args)
{
$logger = self::getInstance();

// nothing passed in, don't do anything
if (count($args) == 0 && $type != self::GROUP_END) {
return;
if (empty($args) && $type != self::GROUP_END) {
return $logger;
}

$logger = self::getInstance();

$logger->_processed = array();

$logs = array();
foreach ($args as $arg) {
$logs[] = $logger->_convert($arg);
}
$logs = array_map(array($logger, '_convert'), $args);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the array syntax should be short syntax because of consistency. Using the [....] instead.

And this short syntax is supported sine the php-5.4+.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in PR #6.


$backtrace = debug_backtrace(false);
$level = $logger->getSetting(self::BACKTRACE_LEVEL);

$backtrace_message = 'unknown';
if (isset($backtrace[$level]['file']) && isset($backtrace[$level]['line'])) {
if (isset($backtrace[$level]['file'], $backtrace[$level]['line'])) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is about two styles for presenting check two values will be set.

If we accept this, we should change all related conditions to this in this respo.

$backtrace_message = $backtrace[$level]['file'] . ' : ' . $backtrace[$level]['line'];
}

$logger->_addRow($logs, $backtrace_message, $type);

return $logger;
}

/**
Expand Down