Skip to content

comment on timestamp diag test #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

comment on timestamp diag test #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/simulator/test_diagnostic_timestamps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ def ddt_test_id(self):
return self._testMethodName.split("_")[-1]

def test_dump_diags_timestamps(self):
"""
This test was made to run for a long time to make sure we do not have rounding
errors in the way the time is set in PHARE. Before, time was incrementally increase
by dt, leading to rounding errors, leading to key errors while reading diags. Now with the
ConstantTimeStamper, we iterate the time INDEX and get the current time increment
from start time, which removes the rounding error.
"""
print("test_dump_diags dim/interp:{}/{}".format(1, 1))

simulation = ph.Simulation(**simArgs.copy())
Expand Down
Loading