schedule/refiner refactor investigation (WIP) #1079
Conversation
PhilipDeegan
force-pushed
the
reschedule
branch
from
c21f514 to
dd6420b
Compare
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #include "amr/resources_manager/amr_utils.hpp" | ||
| #include "core/data/grid/gridlayout_utils.hpp" | ||
| #include "core/data/ions/ions.hpp" | ||
| // #include "core/data/ions/ions.hpp" |
Check notice
Code scanning / CodeQL
Commented-out code Note
| #include "amr/messengers/messenger.hpp" | ||
| #include "amr/resources_manager/amr_utils.hpp" | ||
| #include "amr/messengers/hybrid_messenger.hpp" | ||
| // #include "amr/physical_models/hybrid_model.hpp" |
Check notice
Code scanning / CodeQL
Commented-out code Note
|
|
||
| #include "messenger_info.hpp" | ||
| //#include "core/data/grid/gridlayout.hpp" | ||
| // #include "core/data/grid/gridlayout.hpp" |
Check notice
Code scanning / CodeQL
Commented-out code Note
| template<auto rtype> | ||
| auto& register_resource(auto& rm, auto& dst, auto& src, auto& scratch, auto&&... args) | ||
| { | ||
| auto&& [idDst, idSrc, idScrtch] = rm->getIDsList(dst, src, scratch); |
Check notice
Code scanning / CodeQL
Unused local variable Note
| void scheduler(amr::RefinerScheduler& schedulr) { scheduler_ = &schedulr; } | ||
|
|
||
| template<auto rtype> | ||
| void fill(std::string const& dst, auto& level, double time, auto&&... args) |
Check notice
Code scanning / CodeQL
Unused static variable Note
| void scheduler(amr::RefinerScheduler& schedulr) { scheduler_ = &schedulr; } | ||
|
|
||
| template<auto rtype> | ||
| void fill(std::string const& dst, auto& level, double time, auto&&... args) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| // void fillPopMomTensor(auto& lvl, auto const time, auto const popidx) | ||
| // { | ||
| // using value_type = TensorFieldT::value_type; | ||
| // auto constexpr N = core::detail::tensor_field_dim_from_rank<2>(); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // auto& rm = *model_.resourcesManager; | ||
| // auto& ions = model_.state.ions; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // ions[popidx].momentumTensor()[c].size() * sizeof(value_type)); | ||
|
|
||
| MTAlgos[popidx].getOrCreateSchedule(hierarchy_, lvl.getLevelNumber()).fillData(time); | ||
| // MTAlgos[popidx].getOrCreateSchedule(hierarchy_, lvl.getLevelNumber()).fillData(time); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Momentum TensorField fill borders during diags
PhilipDeegan
force-pushed
the
reschedule
branch
from
dd6420b to
4cddf26
Compare
1 participant
Some investigation on possible Refiner/RefinerPool removal/refactor
End goal really is to remove all the virtual functions like "fillMagneticGhosts" and just deal with right quantites and transaction type (refinement/ghost copy/etc) at the call site.