Potential fix for code scanning alert no. 2: Arbitrary file access during archive extraction ("Zip Slip") #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/P3GLEG/Whaler/security/code-scanning/2
To fix this issue, you need to ensure that the path constructed from each tar entry name (
name
) does not contain any directory traversal elements (..
) or absolute paths that would allow extraction outside of the target directory. The best solution is to:..
elements, absolute paths, or any path separators that could navigate outside the destination directory.filepath.Clean
, then verify the resulting path starts with the extraction directory (i.e., the joined directory path for the layer).In main.go, you need to:
os.MkdirAll
(directory creation) andos.WriteFile
(file extraction), to ensure only safe paths are used.You do NOT need new external dependencies—just Go's standard library.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.