Skip to content

Conversation

pcrumley
Copy link

Hi!

Apologies for just opening a PR without talking to you first, but I found your crate useful and I had a few minor changes i thought you wouldn't mind taking.

  1. you don't need a mutable reference to Parts when you extract the headers
  2. It's a good idea to remove passwords from the debug implementation of auth structs.

If you don't like my suggestions, feel free not to merge them in.

patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant