Skip to content

fix(ios): improve bundle identifier detection and replacement #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smithemely
Copy link

  • fix: handle both quoted and unquoted bundle identifiers
  • feat: implement smarter base identifier detection logic
  • fix: properly preserve extensions with multiple segments

…edGuy#86)

* fix: handle both quoted and unquoted bundle identifiers
* feat: implement smarter base identifier detection logic
* fix: properly preserve extensions with multiple segments
@smithemely
Copy link
Author

I tested the updated implementation with various bundle identifier patterns in real projects, and it works correctly. The solution now handles:

  • Both quoted and unquoted identifiers
  • Extensions with multiple segments and dots
  • Preservation of specialized extension (.RunnerTests)
  • Proper detection of base identifiers

This fix ensures bundle identifiers are consistently renamed throughout the project file while maintaining the structure of complex extension identifiers. It's more robust than the previous implementation.

@OutdatedGuy
Copy link
Owner

I'll test this once I get some free time. Although I was thinking of adding an additional property where users can provide the old package name, so no need for any complex logic.

@OutdatedGuy OutdatedGuy changed the title fix(ios): improve bundle identifier detection and replacement (#86) fix(ios): improve bundle identifier detection and replacement Apr 29, 2025
@OutdatedGuy OutdatedGuy linked an issue Apr 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with PRODUCT_BUNDLE_IDENTIFIER handling in iOS projects
2 participants