Skip to content

Move normalization logic back to common sources #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

OptimumCode
Copy link
Owner

After #278, the normalization library supports wasmJs target out-of-the-box and we can move the normalization logic back to common sources

@OptimumCode OptimumCode added internal Changes in internal part of the library maintenance maintenance task labels Mar 23, 2025
@OptimumCode OptimumCode enabled auto-merge (squash) March 23, 2025 16:23
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: fe10cdd Previous: f9d460c Ratio
macosArm64.CommonAvgTimeBench.validateVerbose ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) 8825.376181102361 us/op 5518.65594888889 us/op 1.60

This comment was automatically generated by workflow using github-action-benchmark.

CC: @OptimumCode

@OptimumCode OptimumCode merged commit 9acfbbd into main Mar 23, 2025
19 checks passed
@OptimumCode OptimumCode deleted the common-normalization branch March 23, 2025 16:38
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.76%. Comparing base (f9d460c) to head (fe10cdd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files         137      137           
  Lines        4073     4073           
  Branches     1087     1087           
=======================================
  Hits         3697     3697           
  Misses         81       81           
  Partials      295      295           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes in internal part of the library maintenance maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant