use ref instead of url for clarity CU-86dxhr7zg #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
Refactoring the targeting configuration parameter from
url
toref
for better semantic clarity and consistency.What is changed?
The change renames the
additionalTargetingSignals.url
parameter toadditionalTargetingSignals.ref
throughout the codebase. This affects:lib/config.ts
lib/edge/targeting.ts
lib/config.test.ts
,lib/edge/targeting.test.js
)The functionality remains identical - the parameter still captures the current page URL/reference for targeting purposes.
The change has been made an approved in edge already.
How to test the changes?
Automated tests:
lib/config.test.ts
verify the newref
parameter works correctlylib/edge/targeting.test.js
ensure the ref parameter is properly included/excluded based on configurationref: true
,ref: false
,ref: undefined
, and when not providedManual testing:
The change is simple enough, well covered by tests.
Dependency changes?