Fix #1834 - anointing Sanctuary allocates ascendancy node #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue with amulet anoints where a notable shares a name with an ascendancy node. Sanctuary is both a normal notable, and a node in the Inquisitor ascendancy. When building the `notableMap` in PassiveTree.lua, the ascendancy node overwrites the normal notable. This `notableMap` is only used to look up notables for "allocates X" stats, which cannot allocate ascendancy nodes. Accordingly, this patch checks whether a node is part of an ascendancy before adding it to the `notableMap`. Test notes: Create an amulet with "Allocates Sanctuary". Without this patch, you will not get the benefits of Sanctuary, the notable will not be lit up on the tree, and the Inquisitor ascendancy notable will be lit. With this patch, the correct node will be lit, and (if you have a shield) you will see the effects of the notable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with amulet anoints where a notable shares a
name with an ascendancy node. Sanctuary is both a normal notable, and a
node in the Inquisitor ascendancy. When building the
notableMapinPassiveTree.lua, the ascendancy node overwrites the normal notable. This
notableMapis only used to look up notables for "allocates X" stats,which cannot allocate ascendancy nodes. Accordingly, this patch checks
whether a node is part of an ascendancy before adding it to the
notableMap.Test notes:
Create an amulet with "Allocates Sanctuary". Without this patch, you
will not get the benefits of Sanctuary, the notable will not be lit up
on the tree, and the Inquisitor ascendancy notable will be lit. With
this patch, the correct node will be lit, and (if you have a shield) you
will see the effects of the notable.