Handle virtual packages in dpkginfo probe #2255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change handles virtual packages in dpkginfo probe by parsing the "Provides" field of /var/lib/dpkg/status. Instead of relying on the "Package" field exclusively, this change also matches the requested package name with the package names listed in the "Provides" field. It should allow to query virtual package names like "system-log-daemon" to actually installed packages likes "rsyslog" and so on. See deb-control(5).
|
Is the PR still WIP? I see that we don't really have a test for |
|
BTW if enabled |
|
I'd like to have feedback from @a-skr to confirm it solves his issue. Yes, it would be nice to add tests from the dpkg probe, since it's pretty much untested by the CI currently. |
|
I just checked, and the issue is solved. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change handles virtual packages in dpkginfo probe by parsing the "Provides" field of /var/lib/dpkg/status.
Instead of relying on the "Package" field exclusively, this change also matches the requested package name with the package names listed in the "Provides" field.
It should allow to query virtual package names like "system-log-daemon" to actually installed packages likes "rsyslog" and so on.
See deb-control(5).
This PR is currently a work-in-progress.