riak-admin tictacaae CLI tests #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmmr
changed the title
aef-
reviewed
Sep 3, 2025
| fun(Var, Val) -> | ||
| Cmd = ff("tictacaae ~s -n ~s", [Var, Node1]), | ||
| Expect = ff("|~s| *~s *|", [Node1, Val]), | ||
| check_admin_cmd(Node1, Cmd, Expect), |
There was a problem hiding this comment.
This and several others look like they will return ok|fail without any assertion.
There was a problem hiding this comment.
My bad. Addressed in aec2318.
hmmr
changed the title
hmmr
changed the title
|
Pending reviews in OpenRiak/poolboy#1, OpenRiak/riak_kv#31 and OpenRiak/riak_core#20, to run this test, your riak needs to have riak_kv, riak_core and poolboy deps checked out from branch "tiot/openriak-3.4/tictacaae-and-nextgenrepl-cli-commands" ("..-3.2/.." for poolboy) and symlinked to _checkouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests for tictacaae CLI riak admin commands (OpenRiak/riak#13, OpenRiak/riak_kv#31; see this Feature proposal).