Skip to content

Conversation

@navi-desu
Copy link
Member

add a deprecation warning for cgroups v1, and rework rc-cgroups.sh into cgroups.sh with an api focused on cgroups v2

move into a new layout with a supervision root cgroup as /rc, services will then go in /rc/$RC_SVCNAME, and compatibility with the old /openrc.$RC_SVCNAME is kept though restarting a service will use the new layout

this also fixes a bug where cgroup_cleanup would not ever trigger due to a bug in cgroup_running

i'll also add support for cgroups in user services to this PR later

@N-R-K
Copy link
Contributor

N-R-K commented Mar 30, 2025

It'd be easier to review (and cleaner git log for reading and/or bisecting) if the cosmetic changes and functional changes were separated into different commits.

@navi-desu
Copy link
Member Author

It'd be easier to review (and cleaner git log for reading and/or bisecting) if the cosmetic changes and functional changes were separated into different commits.

tried my best to split them, tho 4/5 will still be a big commit since it changes the internal cgroups api

move into a new layout with a supervision root cgroup as /rc, services
will then go in /rc/$RC_SVCNAME, and compatibility with the old
/openrc.$RC_SVCNAME is kept though restarting a service will use the new
layout

this also fixes a bug where cgroup_cleanup would not ever trigger due to
a bug in cgroup_running
@N-R-K
Copy link
Contributor

N-R-K commented Mar 30, 2025

tho 4/5 will still be a big commit

That's fine. I don't suggest splitting needlessly just to reduce commit size. If a cosmetic change unintentionally changes functionality then it's not immediately obvious whether it was intentional or not if it's lumped into a functional commit. Having them on their own commit makes this clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants