rc-status: Remove unnecessary checks in print_services(). #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
okay i found one issue with this patch, stacked runlevels are shown when they shouldn't although i think i can fix it without all that complexity |
Member
Author
|
ls_dir is erroneusly including directories when LS_INITD is set, which makes rc_services_in_runlevel return stacked runlevels as well. this bug was hidden in rc-status due to the unnecessary double check on every printed service. |
Every caller of the function already gets a list of services from a valid librc api, and does filtering themselves.
ls_dir is used to list services in a runlevel, in which directories are stacked runlevels, not init scripts. And in general, folders are not allowed in init.d dirs anyway.
williamh
force-pushed
the
rc-status-checks
branch
from
82e41fe to
78d9379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every caller of the function already gets a list of services from a valid librc api, and does filtering themselves.
The rc_service_in_runlevel specially is quite clear to me that it doesn't really matter.
The deptree check seems useless, it just checks if it's on the deptree and filters the service if not, but callers already get those service lists from proper functions. If anyone sees the use for the deptree check, do tell