bootmisc: use find ... -delete for all cleanup in tmp directories

conf.d/bootmisc

@@ -1,4 +1,6 @@
-# List of /tmp directories we should clean up
+# List of /tmp-like directories we should clean up.  tmpfs mounts are ignored
+# since they will be empty at boot.
+# Use of tmpfs for /tmp itself is strongly recommended if possible.
 clean_tmp_dirs="/tmp"
 
 # Should we wipe the tmp paths completely or just selectively remove known

init.d/bootmisc.in

@@ -25,36 +25,24 @@ cleanup_tmp_dir()
 	local dir="$1"
 
 	if ! [ -d "$dir" ]; then
-		mkdir -p "$dir" || return $?
+		mkdir -p "$dir"
+		return $?
 	fi
 	checkpath -W "$dir" || return 1
 	chmod a+rwt "$dir" 2> /dev/null
 	cd "$dir" || return 1
 	if yesno $wipe_tmp; then
 		ebegin "Wiping $dir directory"
 
-		# Faster than raw find
-		if ! rm -rf -- [!ajlq\.]* 2>/dev/null ; then
-			# Blah, too many files
-			find . -maxdepth 1 -name '[!ajlq\.]*' -exec rm -rf -- {} +
-		fi
+		find "${dir}" -depth -xdev ! -type d -exec rm -- {} +
+		find "${dir}" -depth -xdev -type d -empty -exec rmdir -- {} +
 
 		# pam_mktemp creates a .private directory within which
 		# each user gets a private directory with immutable
 		# bit set; remove the immutable bit before trying to
 		# remove it.
 		[ -d /tmp/.private ] && chattr -R -a /tmp/.private 2> /dev/null
 
-		# Prune the paths that are left
-		find . -maxdepth 1 \
-			! -name . \
-			! -name lost+found \
-			! -name quota.user \
-			! -name aquota.user \
-			! -name quota.group \
-			! -name aquota.group \
-			! -name journal \
-			-exec rm -rf -- {} +
 		eend 0
 	else
 		ebegin "Cleaning $dir directory"