Feature: Add debug message for ServerAlias directive #1391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @this-is-varunxyz , thank you for the PR! I will add notes to the review. Personally I wouldn't file a ticket for such cosmetic change (adding a debug message) - the PR with explanation is fine. |
zdohnal
requested changes
Oct 17, 2025
| } | ||
|
|
||
| cupsdAddAlias(ServerAlias, value); | ||
| cupsdLogMessage(CUPSD_LOG_DEBUG, "Added ServerAlias %s", value); |
There was a problem hiding this comment.
Please adjust the indentation as described in DEVELOPING.md, and add a dot at the end of the message. Thank you!
|
One minor note here - if the LogLevel isn't set prior to the ServerAlias line, nothing will be logged... ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1390
This PR adds a debug log message to the scheduler to confirm when a
ServerAliasdirective is successfully loaded from thecupsd.conffile.