feat: sets trim-poly-G as True for one-color-system too (iSeq 100) #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be missing a few (like VL and VH) -- I started a PR a while back in #508 but I don't think it was ever disscused more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastpalready sets--trim_poly_gfor two-color-systems (NEXTSEQ500, NEXTSEQ 550/550DX, NOVASEQ), but does not do the same for iSeq, which is a one color system.Users of iSeq face the same poly-G issues as those of the other platforms mentioned, so it would make sense to also trim poly-Gs by default.