Skip to content

Allow specifying the bind address in the config file #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dongresource
Copy link
Member

  • Should the HTTP and HTTPS endpoints always share a bind address or should they be separately configurable?
  • Should the bind_ip and port configurations be unified into a single field?
  • Should the default be changed to 0.0.0.0 or should it stay as localhost?
  • Should there be a default value or should the absence of the field be an error?

@yungcomputerchair
Copy link
Member

  • I think it would make sense to have the bind address be separately configurable for HTTP and HTTPS. You can just add the bind_ip field to the TlsConfig as well so it mirrors what you have now in CoreConfig.
  • nah, the port is used separately in the code so the port and bind IP should be separate fields
  • I'm not an expert on this one, I thought there was a good security reason for having it be localhost instead of 0.0.0.0 but I can't recall what it is
  • since port is optional, we should either make the bind IP optional as well with a localhost or 0.0.0.0 fallback OR make the port a required value as well. I think the latter would be Bad™️ to do for config backcompat. So probably make the IP optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants