Misc changes to defaults #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongresource
commented
Nov 17, 2024
dongresource
commented
- Listen for HTTP connections on port 8080 by default
- Disable HTTPS by default
- Disable rank endpoint placeholders by default
- Change line endings in config.toml to Unix-style
- Hoist built-in config default to top of main.rs
- Send newline at the end of version endpoint text
- Update .gitignore for cargo-vet
* Listen for HTTP connections on port 8080 by default * Disable HTTPS by default * Disable rank endpoint placeholders by default * Change line endings in config.toml to Unix-style * Hoist built-in config default to top of main.rs * Send newline at the end of version endpoint text * Update .gitignore for cargo-vet
yungcomputerchair
requested changes
Nov 22, 2024
| @@ -51,7 +56,6 @@ impl Config { | |||
| struct AppState { | |||
| db: Arc<Mutex<Connection>>, | |||
| rng: Arc<SystemRandom>, | |||
| is_tls: bool, | |||
There was a problem hiding this comment.
I would actually keep this (and the assertions) but maybe rename to something like is_secure to align with our discussion
| env!("CARGO_PKG_VERSION"), | ||
| state.is_tls | ||
| state.is_using_app_tls() |
There was a problem hiding this comment.
See previous comment; this is supposed to indicate whether secure APIs are enabled, not whether app-terminated TLS is enabled
yungcomputerchair
force-pushed
the
main
branch
2 times, most recently
from
4751fbb to
15d9b51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.