Fix inner class naming in KSP to match KAPT behavior #1317
+60
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change queryClassName generation to use underscore separator for nested classes - Maintains compatibility with existing KAPT-generated Q-classes - Add comprehensive test cases for inner class naming scenarios Fixes: Inner classes now generate QOuterClass_InnerClass instead of QInnerClass This ensures seamless migration from KAPT to KSP without breaking existing code.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 812 837 +25
Lines 31149 31484 +335
Branches 3536 3545 +9
=======================================
- Misses 31149 31484 +335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When migrating from KAPT to KSP, inner class naming conventions differ:
QOuterClass_InnerClassQInnerClassThis breaks existing code that relies on KAPT naming conventions.
Solution
Modified
QueryModelExtractor.queryClassName()to:generateSequenceChanges
Test Cases
OuterClass.InnerClass→QOuterClass_InnerClassA.B.C→QA_B_CTopLevel→QTopLevelBreaking Changes
None - this fixes compatibility issues rather than introducing them.