-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Implement loading of extensions from config files #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guanzi008
wants to merge
4
commits into
OpenAtom-Linyaps:master
Choose a base branch
from
guanzi008:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3213d09
feat: Implement loading of extensions from config files
guanzi008 c40805b
feat: Implement loading of extensions from config files....
guanzi008 ef0a753
feat: Implement loading of extensions from config files....
guanzi008 bf24e83
feat: Implement loading of extensions from config files....
guanzi008 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,6 +95,87 @@ $defs: | |
| destination: | ||
| type: string | ||
| description: mount source file to the another position of container | ||
| LlCliFilesystemEntry: | ||
| title: LlCliFilesystemEntry | ||
| description: filesystem entry used by ll-cli configuration | ||
| type: object | ||
| required: | ||
| - host | ||
| - target | ||
| properties: | ||
| host: | ||
| type: string | ||
| description: source path on host | ||
| target: | ||
| type: string | ||
| description: mount target path inside container | ||
| mode: | ||
| type: string | ||
| description: mount mode, either ro or rw | ||
| persist: | ||
| type: boolean | ||
| description: whether this mount should persist in sandbox storage | ||
| LlCliCommandConfig: | ||
| title: LlCliCommandConfig | ||
| description: per-command overrides for ll-cli configuration | ||
| type: object | ||
| properties: | ||
| env: | ||
| type: object | ||
| description: environment variables applied to command | ||
| additionalProperties: | ||
| type: string | ||
| filesystem: | ||
| type: array | ||
| description: filesystem entries applied to command | ||
| items: | ||
| $ref: '#/$defs/LlCliFilesystemEntry' | ||
| args_prefix: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 有一些配置项好像没用到,如果还没有实现功能,就先把配置项去掉 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这个是准备把配置写到应用的linglong.yaml |
||
| type: array | ||
| description: arguments prepended before command | ||
| items: | ||
| type: string | ||
| args_suffix: | ||
| type: array | ||
| description: arguments appended after command | ||
| items: | ||
| type: string | ||
| entrypoint: | ||
| type: string | ||
| description: override entrypoint for command | ||
| cwd: | ||
| type: string | ||
| description: working directory for command | ||
| LlCliConfig: | ||
| title: LlCliConfig | ||
| description: default ll-cli configuration provided by package | ||
| type: object | ||
| properties: | ||
| filesystem_allow_only: | ||
| type: array | ||
| description: explicit mount allowlist; when present only these mounts are permitted | ||
| items: | ||
| $ref: '#/$defs/LlCliFilesystemEntry' | ||
| filesystem: | ||
| type: array | ||
| description: additional filesystem mounts appended to defaults | ||
| items: | ||
| $ref: '#/$defs/LlCliFilesystemEntry' | ||
| env: | ||
| type: object | ||
| description: default environment variables | ||
| additionalProperties: | ||
| type: string | ||
| commands: | ||
| type: object | ||
| description: command specific overrides | ||
| additionalProperties: | ||
| $ref: '#/$defs/LlCliCommandConfig' | ||
| extensions: | ||
| type: array | ||
| description: default extensions applied when launching app | ||
| items: | ||
| type: string | ||
| ContainerProcessStateInfo: | ||
| description: | | ||
| information about process which in container that start by ll-cli, all content | ||
|
|
@@ -312,6 +393,9 @@ $defs: | |
| type: string | ||
| permissions: | ||
| $ref: '#/$defs/ApplicationConfigurationPermissions' | ||
| cli_config: | ||
| $ref: '#/$defs/LlCliConfig' | ||
| description: default ll-cli configuration delivered with package | ||
| runtime: | ||
| type: string | ||
| description: used runtime of package | ||
|
|
@@ -604,6 +688,9 @@ $defs: | |
| description: description of extension | ||
| items: | ||
| $ref: '#/$defs/ExtensionDefine' | ||
| cli_config: | ||
| $ref: '#/$defs/LlCliConfig' | ||
| description: default ll-cli configuration provided by package | ||
| ext_impl: | ||
| $ref: '#/$defs/ExtensionImpl' | ||
| PackageInfo: | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议整理一下,命令不要加Ll这种奇怪的前缀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的。