improve code clarity for multisig subauth #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const uniqueRequiredAuthsWithSubAuth = await Promise.all(uniqueRequiredAuthsWithSubAuthPromises) | ||
| return uniqueRequiredAuthsWithSubAuth | ||
| this._requiredAuthorizationsWithSubAuths = uniqueRequiredAuthsWithSubAuth |
Collaborator
There was a problem hiding this comment.
Earlier this method used to return [] containing requiredAuthsWithSubAuths but right now it doesn't return anything, This might impact the service - getRequiredAuthorizationsForTransaction method
Contributor
Author
There was a problem hiding this comment.
Good catch.
But service (and other code) should use the public, standard interface Transaction.requiredAuthorizations() - that's what it is there for. Please fix service to use the correct property.
Collaborator
|
@traylewin Do we need this PR or should we close this? |
WarrickFitz
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR needs tests