Skip to content

Conversation

BreathingFlesh
Copy link
Contributor

@BreathingFlesh BreathingFlesh commented Sep 17, 2025

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Landsgemeinde: Import assembly as zip file

TYPE: Feature
LINK: OGC-2272

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have updated the PO files
  • I have tested my code thoroughly by hand

Copy link

linear bot commented Sep 17, 2025

[f for f in html_path.glob('*.html')
if f.name != 'combined_clean.html'],
key=lambda f: [int(s) if s.isdigit() else -1
for s in re.findall(r'\d+|\D+', f.name)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the is a natural sorting available in python: https://www.geeksforgeeks.org/python/python-natsorted-function/

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 16.53543% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.82%. Comparing base (c0be3d5) to head (f2d2a75).
⚠️ Report is 18 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/landsgemeinde/forms/agenda.py 15.51% 98 Missing ⚠️
src/onegov/landsgemeinde/views/agenda.py 27.27% 8 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/landsgemeinde/layouts/assembly.py 96.66% <ø> (ø)
src/onegov/landsgemeinde/views/agenda.py 83.83% <27.27%> (-7.08%) ⬇️
src/onegov/landsgemeinde/forms/agenda.py 47.39% <15.51%> (-48.71%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0be3d5...f2d2a75. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BreathingFlesh BreathingFlesh merged commit 26390a4 into master Sep 23, 2025
25 of 27 checks passed
@BreathingFlesh BreathingFlesh deleted the ogc-2272-import-assembly-item-text branch September 23, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants