Skip to content

Conversation

pmikolajczyk41
Copy link
Member

@pmikolajczyk41 pmikolajczyk41 commented Sep 19, 2025

This PR cleans up the API and internals of the data streaming protocol for DA, extracted in #3603 and #3625.

  1. Abstract signing and verifying messages within the protocol. Instead of using das.SignatureVerifier and das.applyDasSigner we can now use pure signing utilities from signature package. This allows avoiding overhead for building Merkle tree over each payload.
  2. Moved both sender and receiver parts to a separate submodule (hiding internals, enhancing modularity, cleaning up dependencies).
  3. Added basic tests for the protocol.
  4. Made sender generic over the return type (i.e., return whatever server returns, stop depending on the concrete StoreResult from DA RPC server)
  5. Removed rpcClientSendChunkSuccessGauge and rpcClientSendChunkFailureGauge from the RPC client - these were low-level-implementation-details-based metrics that would have to be strangely passed to the DataStreamer
  6. Minor refactoring, renaming, fixed few typos and license headers.

part of: NIT-3846

@pmikolajczyk41 pmikolajczyk41 marked this pull request as ready for review September 19, 2025 13:50
@pmikolajczyk41 pmikolajczyk41 changed the title [WIP] Data stream improvements Data stream improvements Sep 19, 2025
@Tristan-Wilson Tristan-Wilson added this pull request to the merge queue Sep 23, 2025
Merged via the queue into master with commit 298271b Sep 23, 2025
20 of 22 checks passed
@Tristan-Wilson Tristan-Wilson deleted the pmikolajczyk/data-stream-improvements branch September 23, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants