fix: make Log2Floor and Log2Ceil return 0 for input 0 instead of panicking #3652
+368
−262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljobe
requested changes
Sep 22, 2025
There was a problem hiding this comment.
@oooLowNeoNooo, we really only have separate bold.math and arbmath packages because bold used to be in a separate github repository.
Would you consider moving this bold.math package over into arbmath so that we only have one implementation of Log2Ceil across the codebase?
eljobe
reviewed
Oct 1, 2025
| }) | ||
| } | ||
|
|
||
| func FuzzUnsingedIntegerLog2Floor(f *testing.F) { |
There was a problem hiding this comment.
Please also bring over the fuzzing and benchmarking tests.
eljobe
approved these changes
Oct 1, 2025
|
Please fix up the lint errors as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inconsistent behavior between bold/math and util/arbmath log2 implementations
This inconsistency was causing potential issues in critical code paths like
bold/state-commitments/history/history_commitment.go where Log2Floor is used
for Merkle tree depth calculations.
Changes:
This change is mathematically sound for tree depth calculations where log2(0) = 0
represents zero depth needed for zero elements.