V3 support #117
Open
V3 support #117
+192
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e03e48.
gzeoneth
reviewed
Mar 31, 2025
scripts/config.ts
Outdated
| @@ -292,7 +298,7 @@ function writeConfigs(argv: any) { | |||
| if (argv.simple) { | |||
| let simpleConfig = JSON.parse(baseConfJSON) | |||
| simpleConfig.node.staker.enable = true | |||
| simpleConfig.node.staker["use-smart-contract-wallet"] = true | |||
| simpleConfig.node.staker["use-smart-contract-wallet"] = false | |||
There was a problem hiding this comment.
TODO: use-smart-contract-wallet is not working because nitro send gas estimate from address(0), so 1) it required address(0) to have eth AND 2) address(0) calling the validator wallet will revert with NotExecutorOrOwner
* chore: remove bold upgrader * feat: deploy stylue deployer using create2 * fix: log * chore: use v3.1.0 bytecode * chore: import nitro-contract 3.1.0
|
I think we can merge this and resolve the outstanding TODOs later |
TucksonDev
approved these changes
May 6, 2025
There was a problem hiding this comment.
LGTM.
Summarizing the open issues (we can potentially tackle these in a different PR):
- Issues with use-smart-contract-wallet : pointed out in this comment
- Issues with gas estimations sent from address 0x0. A workaround is in place here.
- This PR pins geth version to v1.14.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasebut notmaster