Skip to content

Sast/release ports #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Sast/release ports #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d06b8fd
Add possible fixes (commented out)
acodrington Nov 16, 2023
3e3fbb0
Set LingerState
acodrington Nov 16, 2023
6fd2163
Merge branch 'main' into sast/release-ports
acodrington Nov 16, 2023
91999e3
CloseImmediately
acodrington Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/Halibut/Transport/TcpClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ void DisposeClient()
{
try
{
client.CloseImmediately();
((IDisposable) client).Dispose();
}
catch (SocketException)
Expand Down
2 changes: 1 addition & 1 deletion source/Halibut/Transport/TcpConnectionFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ internal static TcpClient CreateTcpClientAsync(AddressFamily addressFamily, Hali
var client = new TcpClient(addressFamily)
{
SendTimeout = (int)halibutTimeoutsAndLimits.TcpClientSendTimeout.TotalMilliseconds,
ReceiveTimeout = (int)halibutTimeoutsAndLimits.TcpClientReceiveTimeout.TotalMilliseconds
ReceiveTimeout = (int)halibutTimeoutsAndLimits.TcpClientReceiveTimeout.TotalMilliseconds,
};

if (client.Client.AddressFamily == AddressFamily.InterNetworkV6)
Expand Down