tests: Enable tests for gunittest's test_assertions_vect.py #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tedFailure to enable running the remaining of the file
github-actions
bot
added
macOS
|
This is also low risk, it reenables existing tests from a single file, that was disabled because of one single test. They were already running in CI on windows, but the file was excluded on Linux and macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was preparing some changes in gunittest code, and noticed that a whole set of asserts were not tested, and there was a typo in one of them for more than a decade. Unfortunately, the tests here weren't checking for this particular assert.
The file was excluded because of one error that is unrelated to the problem I found.
By making it an expected failure, the 10 other tests in the file can be executed.