Skip to content

lib/gis: solve write out conflicts of G_percent/G_progress when multithreading #6121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cyliang368
Copy link
Contributor

@cyliang368 cyliang368 commented Jul 26, 2025

This PR should solve #5776.

If we want to solve writing conflicts to the same place (stderr), it must be serial.

@github-actions github-actions bot added C Related code is in C libraries labels Jul 26, 2025
@petrasovaa
Copy link
Contributor

Thanks! There is probably no better solution, but I think this still needs some benchmark whether this has any impact on the speed.

@marisn
Copy link
Contributor

marisn commented Jul 27, 2025

This should not be merged, as:

@cyliang368
Copy link
Contributor Author

Thanks! There is probably no better solution, but I think this still needs some benchmark whether this has any impact on the speed.

This should not be merged, as:

  • it has a serious speed penalty

It is a very small part, so I believe its impact could be negligible.

I simply ran v.surf.rst and r.univar a few times manually, and I could not tell whether the difference was made by this change or some uncertainty from OS.

I would like to get some benchmarks on r.mapcalc after #5742 is merged.


@marisn Can you elaborate on why you think it does not solve #5776?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants