Silence Gemfile and key warnings #4820
Conversation
apps/dashboard/Gemfile
Outdated
| gem 'ostruct' | ||
| gem 'bigdecimal' | ||
| gem 'mutex_m' |
There was a problem hiding this comment.
Are you still seeing these? I think seeing ostruct is new, but activesupport already has these in rails 7.1, you can see them in your vendor/bundle.
There was a problem hiding this comment.
I wasn't seeing any them during tests, but I figured it was better to be overly cautious in case they were originating somewhere that wasn't being hit. I couldn't find a good way to scan the whole dashboard for depreciation warnings. I will look into them though and see if they were part of the 7.1 upgrade
apps/dashboard/test/fixtures/widgets/recently_used_apps/sys_bc_desktop.json
Show resolved
Hide resolved
|
Not sure how I missed it before, but I also added |
| gem 'ostruct' | ||
| gem 'abbrev' |
There was a problem hiding this comment.
We should put a comment here because these are not direct dependencies but actual like rubygems or bundler dependencies that we're trying to silence.
Which is to say we can get rid of them eventually and/or just not include them now and let bundler/rubygems/whatever update itself on the systems.
There was a problem hiding this comment.
or just not include them now and let bundler/rubygems/whatever update itself on the systems.
Would you rather do that? I was thinking that we were including these in lieu of any upgrades for the moment
There was a problem hiding this comment.
Would you rather do that? I was thinking that we were including these in lieu of any upgrades for the moment
I could go either way.
Fixes #4147 by adding the
ostruct,bigdecimal, andmutex_mgems to the Gemfile. Also silences two duplicated key warnings by resolving the duplication.