-
Couldn't load subscription status.
- Fork 158
Prep OnDemand 4.1 dependencies #4646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
treydock
commented
Sep 30, 2025
- Upgrade NodeJS from 20 to 22
- Upgrade Passenger from 6.0.23 to 6.1.0
- Upgrade NGINX from 1.23.1 to 1.23.3
- Upgrade Dex from 2.41.1 to 2.44.0
|
@johrstrom Seems the built-in npm node-gyp is maybe causing issues with the Python version for some operating systems. That's somewhat strange since both come from the OS. However the syntax error on |
|
It's a native nodejs package. Seems like there are some toggles like the environment variable https://github.com/nodejs/node-gyp
|
|
@johrstrom I managed to get EL8 to work by upgrading to Python 3.12. The options to get 3.8+ was either 3.11 or 3.12 and 3.12 is good till the EOL of the entire EL8 OS rather than 3.11 which is EOL in a year. |
packaging/rpm/ondemand.spec
Outdated
| # Force Python 3.12 for EL8 as Python 3.6 does not work with node-gyp | ||
| %if 0%{?rhel} == 8 | ||
| Requires: python3.12 | ||
| %else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is BuildRequires not enough? Do we really need 3.12 at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@treydock is BuildRequires not enough? Do we really need 3.12 at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I figured if node-gyp needs Python 3.12 at build time, won't it need it at runtime too or is that not what node-gyp does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's used during the build to compile C++ .so files. Once those are built, I don't think it needs it. Or at least this is what I think. I can try to find what those .so files link to, but if anything, I'd imagine they link to nodejs libraries, not python.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to just do BuildRequires for Python 3.12 on RHEL8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! let's see how it fares as a nightly in dev anyhow. I could be wrong.
|
EL9 builds are consistently failing, not clear what's going on |
Like the sudo ERB is not working now. |
* Upgrade NodeJS from 20 to 22 * Upgrade Passenger from 6.0.23 to 6.1.0 * Upgrade NGINX from 1.23.1 to 1.23.3 * Upgrade Dex from 2.41.1 to 2.44.0
|
I just synced UCR, so we should see this in our nightlies tomorrow. |
|
@johrstrom , We need a |
OK, we can tag a start tag today. |
|
@johrstrom Let me know when the start tag is created. |
🤦♂️ I've forgotten about this, but I'll have @Bubballoo3 create a tag today. |